Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse the reader returned by FetchReference #5102

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Reuse the reader returned by FetchReference #5102

wants to merge 2 commits into from

Commits on Oct 10, 2024

  1. Reuse the reader returned by FetchReference 

    FetchReference already returns a reader to the manifest content.
However, content.Successors operates on a Fetcher. In order to funnel
the already open reader into content.Successors, create a FetcherFunc
that returns it.

This saves one additional GET request.

Before:
    GET /v2/repository/artifact/manifests/latest
    GET /v2/repository/artifact/manifests/sha256:341098d11767212bb4d148f3fe8e82fc2939c3be247b233291a62e39a594ed09
    GET /v2/repository/artifact/blobs/sha256:9f86d081884c7d659a2feaa0c55ad015a3bf4f1b2b0b822cd15d6c15b0f00a08

After:
    GET /v2/repository/artifact/manifests/latest
    GET /v2/repository/artifact/blobs/sha256:9f86d081884c7d659a2feaa0c55ad015a3bf4f1b2b0b822cd15d6c15b0f00a08

Signed-off-by: Tom Wieczorek <[email protected]>
    @twz123
    twz123 committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    b123708 View commit details
    Browse the repository at this point in the history

  2. Add some more tests 

    They increase coverage slightly from 85.7% to 87%.

Signed-off-by: Tom Wieczorek <[email protected]>
    @twz123
    twz123 committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    99b7bf3 View commit details
    Browse the repository at this point in the history