Extract iptables binary staging to iptablesutils #5095
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twz123
reviewed
Oct 9, 2024
| // ExtractIPTablesBinaries extracts the iptables binaries from the k0s binary and makes the symlinks | ||
| // to the backend detected by DetectHostIPTablesMode. | ||
| // ExtractIPTablesBinaries only works on linux, if called in another OS it will return an error. | ||
| func ExtractIPTablesBinaries(k0sBinDir string, iptablesMode string) (error, string) { |
There was a problem hiding this comment.
I'd rather add it as a separate "IPTablesSetup" (or sth. like that) component, than having it as a free-standing function.
There was a problem hiding this comment.
Do you mean adding it the same way we do with pkg/component/status and pkg/component/prober?
CPLB potentially will need to create some iptables rules for its userspace proxy, hence this code should be in iptablesutils rather than pkg/worker/kubelet. Signed-off-by: Juan-Luis de Sousa-Valadas Castaño <[email protected]>
juanluisvaladas
force-pushed
the
externalize-ipt
branch
from
83cd0eb
to
be3872c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CPLB potentially will need to create some iptables rules for its userspace proxy, hence this code should be in iptablesutils rather than pkg/worker/kubelet.
Fixes # (issue)
Type of change
How Has This Been Tested?
Checklist: