Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ADOPTERS.md #5088

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Update ADOPTERS.md #5088

merged 2 commits into from
Oct 10, 2024

Conversation

randybias
Copy link
Contributor

@randybias randybias commented Oct 8, 2024 •
edited
Loading

Fixed line breaks. Added vCluster. Fixed a alphabetical sorting error.

Description

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@randybias randybias requested a review from a team as a code owner October 8, 2024 07:54
twz123
twz123 reviewed Oct 8, 2024
View reviewed changes
Copy link
Member

@twz123 twz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to use non-whitespace characters for the linebreaks 👍

Would you also mind to update the comment on lines 9-19 here?

randybias and others added 2 commits October 10, 2024 11:47
@randybias @twz123
Update ADOPTERS.md
7ff59a9 
Fixed line breaks.  Added vCluster.  Fixed a alphabetical sorting error.

Signed-off-by: Randy Bias <[email protected]>
@twz123
Adjust the ADOPTERS comments
6139998 
We're now preferring <br> over two trailing spaces.

Also: strip some unrelated trailing whitespace

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 requested a review from a team as a code owner October 10, 2024 09:52
@twz123 twz123 enabled auto-merge October 10, 2024 09:53
@twz123 twz123 merged commit 0030d86 into k0sproject:main Oct 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twz123 twz123 twz123 left review comments

@juanluisvaladas juanluisvaladas juanluisvaladas approved these changes

@kke kke Awaiting requested review from kke kke is a code owner automatically assigned from k0sproject/k0s-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@randybias @twz123 @juanluisvaladas