Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chart crd forceUpgrade field should be nil by default #5068

Merged
merged 1 commit into from
Oct 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pkg/apis/helm/v1beta1/chart_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ type ChartSpec struct {
Namespace string `json:"namespace,omitempty"`
Timeout string `json:"timeout,omitempty"`
// ForceUpgrade when set to false, disables the use of the "--force" flag when upgrading the the chart (default: true).
// +kubebuilder:default=true
// +optional
ForceUpgrade *bool `json:"forceUpgrade,omitempty"`
Order int `json:"order,omitempty"`
Expand Down
1 change: 0 additions & 1 deletion pkg/apis/k0s/v1beta1/extensions.go
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,6 @@ type Chart struct {
// +kubebuilder:validation:XIntOrString
Timeout BackwardCompatibleDuration `json:"timeout,omitempty"`
// ForceUpgrade when set to false, disables the use of the "--force" flag when upgrading the the chart (default: true).
// +kubebuilder:default=true
// +optional
ForceUpgrade *bool `json:"forceUpgrade,omitempty"`
Order int `json:"order,omitempty"`
Expand Down
1 change: 0 additions & 1 deletion static/_crds/helm/helm.k0sproject.io_charts.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ spec:
chartName:
type: string
forceUpgrade:
default: true
description: 'ForceUpgrade when set to false, disables the use of
the "--force" flag when upgrading the the chart (default: true).'
type: boolean
Expand Down
1 change: 0 additions & 1 deletion static/_crds/k0s/k0s.k0sproject.io_clusterconfigs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,6 @@ spec:
minLength: 1
type: string
forceUpgrade:
default: true
description: 'ForceUpgrade when set to false, disables
the use of the "--force" flag when upgrading the the
chart (default: true).'
Expand Down
Loading