Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let ClusterConfigInitializer apply the api-config stack #5067

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Let ClusterConfigInitializer apply the api-config stack #5067

wants to merge 6 commits into from
+485 −91

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Oct 2, 2024

Description

The k0s managed stacks don't have to live on disk. They can be used directly from in-memory. Let the api-config stack be the first. Include its application in the Start method of the ClusterConfigInitializer. Have the applier manager ignore this stack and write an ignore note in the stack directory.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123
Use lowercase c: clusterConfig.go -> clusterconfig.go
0fec814 
It's more idiomatic to use all-lowercase file names for Go code.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123
Add tests for ClusterConfigInitializer
f069849 
The DefaultClusterConfig function did not set the namespace, which is
required so that the fake clients know which namespace it belongs to
when it is added as an initial object. Also, this function hard-coded
some values for which there are constants.

For reactors to be added, the actual fake types are now exposed in the
fake client factory.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123
Include the last error in ClusterConfigInitializer errors
63967e0 
Signed-off-by: Tom Wieczorek <[email protected]>
@twz123
Add API extensions clients to client factory
19fcd93 
Signed-off-by: Tom Wieczorek <[email protected]>
@twz123
Add some simple tests for the applier manager
07b09b8 
Signed-off-by: Tom Wieczorek <[email protected]>
@twz123
Let ClusterConfigInitializer apply the api-config stack
a9e53d4 
The k0s managed stacks don't have to live on disk. They can be used
directly from in-memory. Let the api-config stack be the first. Include
its application in the Start method of the ClusterConfigInitializer.
Have the applier manager ignore this stack and write an ignore note in
the stack directory.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 marked this pull request as ready for review October 2, 2024 18:33
@twz123 twz123 requested a review from a team as a code owner October 2, 2024 18:33
@twz123 twz123 requested review from ncopa and makhov October 2, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncopa ncopa Awaiting requested review from ncopa ncopa is a code owner automatically assigned from k0sproject/k0s-maintainers

@makhov makhov Awaiting requested review from makhov makhov is a code owner automatically assigned from k0sproject/k0s-maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/controlplane chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@twz123