Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: respect proxy from env when downloading #5064

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

ricardomaraschini
Copy link
Contributor

@ricardomaraschini ricardomaraschini commented Oct 2, 2024

Description

we should respect the proxy env var when downloading files.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

we should respect the proxy env var when downloading files.

Signed-off-by: Ricardo Maraschini <[email protected]>
@twz123 twz123 added component/autopilot backport/release-1.31 PR that needs to be backported/cherrypicked to the release-1.31 branch bug Something isn't working labels Oct 2, 2024
@ricardomaraschini ricardomaraschini merged commit ca87854 into main Oct 2, 2024
92 checks passed
@ricardomaraschini ricardomaraschini deleted the respect-env-proxy-on-download branch October 2, 2024 14:47
@k0s-bot
Copy link

k0s-bot commented Oct 2, 2024

Successfully created backport PR for release-1.31:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/release-1.31 PR that needs to be backported/cherrypicked to the release-1.31 branch bug Something isn't working component/autopilot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants