[Backport release-1.28] Use the correct template when installing as a SystemV service #5051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are no references to this function. Signed-off-by: Kimmo Lehto <[email protected]> (cherry picked from commit ecab42f)
Since k0s does not run on mac, there's no need for launchd service installer. Signed-off-by: Kimmo Lehto <[email protected]> (cherry picked from commit 2227665)
The file was empty except for the copyright header and package name. Signed-off-by: Kimmo Lehto <[email protected]> (cherry picked from commit 96db2f6)
Unlike openrc, upstart and system v unit file templates, the systemd template was defined in pkg/install/service.go. Here it is extracted into a dedicated file like the other templates. Signed-off-by: Kimmo Lehto <[email protected]> (cherry picked from commit edaa054)
The customized system V service template was not being used, as the template was put into "SystemdScript" option. The correct option name seems to be "SysVScript". Signed-off-by: Kimmo Lehto <[email protected]> (cherry picked from commit 36b7bc2)
The openrc unit file template had the "name=" definition twice. I assume it is the last one that was effective. Signed-off-by: Kimmo Lehto <[email protected]> (cherry picked from commit 2a7e7ae)
There are no references to this function. The linter catches is as unused. Signed-off-by: Kimmo Lehto <[email protected]> (cherry picked from commit 416c9ff)
16 tasks
jnummelin
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated backport to
release-1.28, triggered by a label in #5044.See #4962.