[Backport release-1.30] chore(backport): make helm timeout backward compatible

[ricardomaraschini]

Description

backport of #5017

in the past the helm chart install timeout was moved from an integer to a string. this commit brings back the capability of using integers to set the helm chart timeout.

Type of change

• Chore
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update

How Has This Been Tested?

• Manual test
• Auto test added

Checklist:

• My code follows the style guidelines of this project
• My commit messages are signed-off
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• I have checked my code and corrected any misspellings

[laverya]

I'm currently seeing the following journalctl logs after upgrading from 1.29 to 1.30 with a few helm charts in the dynamic config extensions, so hopefully this will fix things!

Sep 26 22:45:59 node0 k0s[10821]: time="2024-09-26 22:45:59" level=info msg="E0926 22:45:59.933059 10856 fieldmanager.go:155] "[SHOULD NOT HAPPEN] failed to update managedFields" err=<" component=kube-apiserver stream=stderr
Sep 26 22:45:59 node0 k0s[10821]: time="2024-09-26 22:45:59" level=info msg="\tfailed to convert new object (kube-system/k0s; k0s.k0sproject.io/v1beta1, Kind=ClusterConfig) to smd typed: errors:" component=kube-apiserver stream=stderr
Sep 26 22:45:59 node0 k0s[10821]: time="2024-09-26 22:45:59" level=info msg="\t .spec.extensions.helm.charts[0].timeout: expected numeric (int or float), got string" component=kube-apiserver stream=stderr
Sep 26 22:45:59 node0 k0s[10821]: time="2024-09-26 22:45:59" level=info msg="\t .spec.extensions.helm.charts[1].timeout: expected numeric (int or float), got string" component=kube-apiserver stream=stderr
Sep 26 22:45:59 node0 k0s[10821]: time="2024-09-26 22:45:59" level=info msg="\t .spec.extensions.helm.charts[2].timeout: expected numeric (int or float), got string" component=kube-apiserver stream=stderr
Sep 26 22:45:59 node0 k0s[10821]: time="2024-09-26 22:45:59" level=info msg="\t .spec.extensions.helm.charts[3].timeout: expected numeric (int or float), got string" component=kube-apiserver stream=stderr
Sep 26 22:45:59 node0 k0s[10821]: time="2024-09-26 22:45:59" level=info msg="\t .spec.extensions.helm.charts[4].timeout: expected numeric (int or float), got string" component=kube-apiserver stream=stderr
Sep 26 22:45:59 node0 k0s[10821]: time="2024-09-26 22:45:59" level=info msg=" > versionKind="k0s.k0sproject.io/v1beta1, Kind=ClusterConfig" namespace="kube-system" name="k0s"" component=kube-apiserver stream=stderr
Sep 26 22:46:00 node0 k0s[10821]: time="2024-09-26 22:46:00" level=info msg="EtcdMember CRD status: False" component=etcdMemberReconciler
Sep 26 22:46:00 node0 k0s[10821]: time="2024-09-26 22:46:00" level=info msg="I0926 22:46:00.664025 10856 handler.go:286] Adding GroupVersion etcd.k0sproject.io v1beta1 to ResourceManager" component=kube-apiserver stream=stderr

[laverya]

And I can confirm that when running with this mechanism, things just work - I don't have to edit our initially-created /etc/k0s/k0s.yaml files to remove the timeouts, and the in-cluster type upgrades properly too!