-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
k0s doesn't fail gracefully on broken kine config #4693
Comments
It has to be done by k0s itself. The only sufficient way I can think of is to utilize the etcd API kine provides to do some sort of ping-pong. Maybe try to write some arbitrary value and see it succeed/fail. The challenge still would be how to convey that to k0sctl side. I mean k0sctl does not really know what k0s is doing per se, it just sees it getting up or not via systemd or other init system. |
In the controller log I notice the kine process is panicking. Does the kine process get restarted by k0s at this point? If so, could k0s do a simple check: is this the first time kine was run, and if so then don't restart but instead quit with an error. |
Yes, k0s acts as a watchdog for kine and all other child processes
I think in general if k0s does not get kine up-and-running, it should eventually give up and quit with error. But then again, k0s is usually watched by systemd or other init system and will get restarted itself. |
The issue is marked as stale since no activity has been recorded in 30 days |
The issue is marked as stale since no activity has been recorded in 30 days |
Before creating an issue, make sure you've checked the following:
Platform
Version
v1.30.2+k0s.0
Sysinfo
`k0s sysinfo`
What happened?
I ran
k0sctl apply
with storage set to use kine, however messed up kinedataSource
(I forgot to set environment variables to populate user,password,host parameters).This caused a few issues:
The k0scontroller log shows kine trying to reach the backend. I see this log message repeated:
To recover, I took these steps:
/etc/k0s/k0s.yaml
to remove kine storage configk0s reset
It would be good for k0s to fail more gracefully e.g. could a smoke test be done with kine prior to deploying k0s?
Steps to reproduce
dataSource: "postgres://:@:5432/kine?sslmode=prefer"
Expected behavior
No response
Actual behavior
No response
Screenshots and logs
k0scontroller log
k0sctl apply output (partial)
Additional context
No response
The text was updated successfully, but these errors were encountered: