Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for kine to be ready during startup #5092

Closed
wants to merge 1 commit into from

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Oct 8, 2024

Description

So k0s will not continue with its startup sequence, and will exit with an error message indicating that kine was not okay.

See:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

So k0s will not continue with its startup sequence, and will exit with
an error message indicating that kine was not okay.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 marked this pull request as ready for review October 8, 2024 15:34
@twz123 twz123 requested a review from a team as a code owner October 8, 2024 15:34
@twz123 twz123 requested review from ncopa and makhov October 8, 2024 15:34
@twz123
Copy link
Member Author

twz123 commented Oct 8, 2024

This is of course superfluous, as this is what the manager.Ready interface and the Ready method are for in the first place 🙄

@twz123 twz123 closed this Oct 8, 2024
@twz123 twz123 deleted the wait-for-kine branch October 8, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant