Merge pull request #4692 from twz123/gold-linker-arm

Only require gold linker on ARM
k0sproject · Jun 28, 2024 · 6dd645a · 6dd645a
2 parents 2402ff0 + 03e8715
commit 6dd645a
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/build/Dockerfile b/build/Dockerfile
@@ -1,6 +1,15 @@
 ARG BUILDIMAGE
 FROM $BUILDIMAGE
-RUN apk add --no-cache make gcc musl-dev binutils-gold
+
+ARG TARGETARCH
+RUN set -ex; \
+# Need to use the gold linker on ARM, Go really wants to have it.
+# https://github.com/golang/go/blob/go1.22.4/src/cmd/link/internal/ld/lib.go#L1622-L1641
+  case "$TARGETARCH" in \
+  arm*) binutils=binutils-gold ;; \
+    *)    binutils=binutils ;; \
+  esac; \
+  apk add --no-cache make gcc musl-dev "$binutils"
 
 ENV \
   HOME="/run/k0s-build" \