Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tenacity dependencity to include 9.0.0 #1042

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Cokral
Copy link

@Cokral Cokral commented Oct 4, 2024

Not sure what more there is to be done for issue #1000 . The version upgrade should not be impacting what is done with tenacity here.

This is my first issue on this package, so not exactly sure how to proceed :).


Important

Update tenacity dependency version constraint to include 9.0.0 in pyproject.toml.

  • Dependencies:
    • Update tenacity version constraint in pyproject.toml to >=8.4.1,<10.0.0 to include version 9.0.0.

This description was created by Ellipsis for 025f1c1. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 025f1c1 in 7 seconds

More details
  • Looked at 20 lines of code in 1 files
  • Skipped 1 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. pyproject.toml:19
  • Draft comment:
    Ensure that the codebase is compatible with tenacity versions up to 9.x, as the version range has been updated to include <10.0.0.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The change in the tenacity version range is appropriate, but it's important to ensure compatibility with the rest of the codebase.
2. pyproject.toml:19
  • Draft comment:
    The change in the tenacity version range is a library code change. Ensure that any necessary documentation and tests are updated accordingly.
  • Reason this comment was not posted:
    Confidence changes required: 80%
    The change in the tenacity version range in the pyproject.toml file is a library code change. According to the rules, this should be accompanied by updates to documentation and tests if applicable. I need to check if these updates are present.

Workflow ID: wflow_Bn3vsPehmuFbKrir


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant