Merge pull request RemedyIT#391 from jwillemsen/jwi-ostreamoptional2

Add ostream logging for optional struct members
jwillemsen · Jun 11, 2024 · cca21bd · cca21bd
2 parents 8096477 + c17bc28
commit cca21bd
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/ridlbe/c++11/templates/cli/hdr/struct_idl_traits_def.erb b/ridlbe/c++11/templates/cli/hdr/struct_idl_traits_def.erb
@@ -34,11 +34,12 @@ struct formatter<<%= scoped_cxxtype %>, OStrm_>
         << "object}"
 %       end
 %     else
-% unless _m.optional? || _m.external?
-        << "<%= _sep %><%= _m.cxxname %>=" << IDL::traits<<%= _m.scoped_cxxtype %>>::write(val_.<%= _m.cxxname %> ())
-% else
+% if _m.optional?
+        << "<%= _sep %><%= _m.cxxname %>="; if (val_.<%= _m.cxxname() %> ().has_value ()) { os_ << IDL::traits<<%= _m.scoped_cxxtype %>>::write(val_.<%= _m.cxxname %> ().value ()); } else { os_ << "std::nullopt"; } os_
+% elsif _m.external?
 %# TODO
-%#         << "<%= _sep %><%= _m.cxxname %>=" << (val_.<%= _m.cxxname() %> ().has_value () ? IDL::traits<<%= _m.scoped_cxxtype %>>::write(val_.<%= _m.cxxname %> ().value ()) : "<empty>")
+% else
+        << "<%= _sep %><%= _m.cxxname %>=" << IDL::traits<<%= _m.scoped_cxxtype %>>::write(val_.<%= _m.cxxname %> ())
 % end
 %     end
 %     _sep = ',' unless _sep

diff --git a/tests/idl4/optional/client.cpp b/tests/idl4/optional/client.cpp
@@ -16,5 +16,8 @@ int main (int /*argc*/, char* /*argv*/[])
   bar mybar;
 
   TAOX11_TEST_INFO << "mybar: " << mybar << std::endl;
+  mybar.z(6);
+  TAOX11_TEST_INFO << "mybar: " << mybar << std::endl;
+
   return retval;
 }
diff --git a/tests/idl4/optional/test.idl b/tests/idl4/optional/test.idl
@@ -8,8 +8,9 @@
 struct bar
 {
   short x;
-  string y;
   @optional short z;
+  long z_long;
   @optional short a;
   @optional string opt_string;
+  string y;
 };