Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move compress() and decompress() to dedicated library crate #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gkaklas
Copy link

@gkaklas gkaklas commented Jun 19, 2023

Hello! Thank you for this utility

These commits add some initial work so the code can be used as a library.

Mainly, the functions compress() and decompress() have been moved from main.rs to a separate crate, but there are also some changes to create a Cargo workspace to organize the crates.

I'm not sure about some details e.g. the name mozlz4-bin, but I see that, for other libraries, the usual scheme is that there is a library crate for general users, and a library-sys used by library for the unsafe functionality, so it seemed appropriate to keep the naming convention and maybe the binary name can be changed in the future.

@jusw85
Copy link
Owner

jusw85 commented Jun 21, 2023

Thanks for this! I'm a little tied up at the moment so it'll be awhile before I take a look at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants