jmartin/xcode 16 #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove check preventing scroll UITableViewCells
Edit mistyping on KIFUITestActor.h
…lling Fixing broken cell scrolling in TableViews
When tapping an element, there is a check that ensures it becomes the first responder within a half second. This doesn't work for elements such as popover controls however, which only become first responder after the popover view finishes being presented (usually animated). In that case, there is a race condition as to whether the element will finish displaying before the polling interval completes. The fix here is to ensure that we wait for any animations to complete before trying to check that the element that has been tapped became first responder. One exception to this is when interacting with an accessibility element and not a view. In this case, the backing view for the may still be visible on screen, even though the element itself is not. An example of this is web views, where this would cause the test `-[WebViewTests testTappingLinks]` to fail.
…-scrolling Fixing UICollectionView cell tapping
…tion-after-first-responder-tapped Fix issue with elements not becoming first responder fast enough
Fix Xcode 11 (Beta) build error (implicit conversion warning)
…tionViewScrollAtPosition Add "atPosition:" variations to UICollectionView waitForCellAtIndexPath methods
Bumping to v3.7.8
This reverts commit f4705fb.
Prevent EXC_BAD_ACCESS crash by null-checking proper error
We need to dig through the hierarchy manually rather than asking for the application's alert Fixes #1125
Fixed acknowledgeSystemAlert on iOS 13.1
Fix bug when acknowledging system alerts in Xcode 11.1
1. Omit the atY: parameter of swipeFromEdge 2. Add an equivalent API to KIFUIViewTestActor and add tests 3. dragFromEdge now uses edgeInset for the top and height - edgeInset for the bottom
Add support for swiping from the specified edge of the screen
…tests PullToRefreshTests can exit before the greetingView is finished animating out
…o-keyboard iOS 17 - fix black screenshots after using a keyboard
…arget Bump ios minimum deployment target - New PR
silencing non-exhaustive switch warning
* adding support for accessibility custom actions
Introduce `-[KIFUITestActor tryFindingViewInFrame]` and `-[KIFUIViewTestActor usingCurrentFrame]`. This can be used to avoid scrolling when looking for a view. This can be helpful where implicit table/collection view scrolling that happens when attempting to find UI elements triggers unwanted behavior (pagination fetch, abort pull to refresh, etc). This includes a behavior change in `isTappable` where it no longer automatically treats an element as tappable just for having a tap gesture recognizer on it, even though it might be occluded. See this discussion for more context: #1296 (comment) --------- Authored-by: Simone Scionti <[email protected]>
Configuring CI to run in 4 configurations: - xcode 14.3.1, iPad Air (5th generation), iOS 16.4 - xcode 14.3.1, iPhone 14, iOS 16.4 - xcode 15.4, iPad Air (5th generation), iOS 17.5 - xcode 15.4, iPhone 15, iOS 17.5 As part of this change, the CI script was updated to only run the extra validation of the examples folder one one of the 4 shards. This removes Carthage from the README as being officially supported. I'd guess that is generally not being used. The CI script hasn't worked since Xcode 12.
* AccessibilityIdentifierTests tests Fix `testEnteringTextIntoViewWithAccessibilityIdentifier` flaking We're trying to tap on `Select All` while it is still being animated into view. The problem is two-fold: 1. The `longPress` action doesn't wait for animations to complete, it just uses a hardcoded .5s before starting the next action. 2. Even after switching to use `waitForAnimationsToFinish`, the timeout defaults to .5s as the max to wait for animations to complete. To fix this, I switched `longPress` action to use `waitForAnimationsToFinish` and I upped the default timeout to wait up to 2s for animations to complete. This seems to work much more reliably now. * SystemTests.testMockingOpenURL NSURL no longer parses '423543523454://', use a different protocol that starts with characters * ExistTests Wait a bit longer for the view controller presentation to complete * TypingTests In TapViewController, avoid race condition in resigning first responder and becoming first responder. CI was flaking with a failure where "Deleted something., world" was found in the greeting text field. * PullToRefreshTests Leverage 'usingCurrentFrame' so we're not scrolling the table view around while the UIRefreshControl is spinning, which immediately halts the refresh spinner. Also, make sure that we're scrolled to the top of the test suite VC, as otherwise the pull to refresh action might fail.
It doesn't really make sense that the default animation wait time is the same as the stabilization time. This effectively means the behavior of scanning the UI hierarchy for animations in progress is never utilized for most tests out of the box. For what its worth, we've used a 2s animation wait time and .1s stabilization time as our defaults for a very long time. This should generally not slow down any tests if there weren't any animations in progress. If there were animations in progress, this is probably a worthwhile tradeoff to make things more reliable. This can still be configured globally to be overidden. As part of this change, use `waitForAnimationsToFinish` in place of a static .5s sleep for the `longPress` action. There will be a followup PR #1301 that should speed up some scenarios where we're waiting longer than desired for animations to complete.
Have the pullToRefresh action pull from 25% of the way down the element to 75% of the way down, instead of pulling from the center and pulling a full height of the element
This removes the `KIFFramework` target and its consumer tests. They don't interop well with the way that angle and quote imports work in SPM. More info: https://joesusnick.medium.com/swift-package-manager-with-a-mixed-swift-and-objective-c-project-part-2-2-e71dad234e6 Took this opportunity to remove the spaces in the target names for the 'Testable Swift' target, in case that was causing issues somewhere.
Two changes: * We won't recurse into layers that are hidden * We don't count animations that run for longer than 1 minute
Credit to @amorde for finding this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure CI to run on Xcode 16.
Stacked on top of kif-framework#1300 and kif-framework#1301.