Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add check to verify if rosetta is installed on macOS #29

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: Add check to verify if rosetta is installed on macOS #29

wants to merge 3 commits into from

Conversation

shivaraj-bh
Copy link
Member

@shivaraj-bh shivaraj-bh commented Jul 12, 2024 •
edited
Loading

resolves #26

@srid
Copy link
Member

srid commented Jul 12, 2024

BREAKING CHANGE: The schema for the flake config of nix-health of rosetta has been changed to rosetta_emulated

What is the reason for the change?

@shivaraj-bh
Copy link
Member Author

BREAKING CHANGE: The schema for the flake config of nix-health of rosetta has been changed to rosetta_emulated

What is the reason for the change?

Actually, it was based on a different idea I had for the implementation. On a second thought, I will revert this.

@srid
Copy link
Member

srid commented Jul 12, 2024 •
edited
Loading

Is there a reason why we can't (or shouldn't) piggyback on the existing Rosetta check?

image

@shivaraj-bh
Copy link
Member Author

Is there a reason why we can't (or shouldn't) piggyback on the existing Rosetta check?

It will involve combining two opposite checks together, doesn’t it? rosetta.enable = true is green if nix-health executable is not running under rosetta emulation and rosetta.installed = true is green if the system has rosetta installed.

srid
srid reviewed Jul 16, 2024
View reviewed changes
Copy link
Member

@srid srid left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the README since we have added a new check? See the "Configuring" section.

Regarding the new check name, rosetta-installed, let me think about this a bit (especially as it will be used in om health as well). I wonder if we should support nested checks ...

src/check/rosetta_installed.rs
{
let check = Check {
title: "Rosetta Installed".to_string(),
info: "".to_string(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be something rather than empty string, so that we don't see an empty line (somewhat confusing) here:

image

@srid
Copy link
Member

srid commented Jul 16, 2024

@shivaraj-bh Let's move this PR to omnix repo.

(No hurry on this one)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srid srid srid left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a health check to confirm that rosetta was installed
2 participants
@shivaraj-bh @srid