Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Pacific Island' no longer matches Iceland (IS) #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mounasb
Copy link
Contributor

@mounasb mounasb commented Oct 29, 2024

No description provided.

@@ -44,6 +44,7 @@
"christmas island": "CX", # en
"heard island": "HM", # en
"norfolk island": "NF", # en
"pacific island": "", # en
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A similar case was encountered for "ocean indien", and the default value was None. I suggest to do the same here, for the data to be consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants