Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove export kernel settings schema json #47

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

echarles
Copy link

@echarles echarles commented May 5, 2023

This removes

export * as KERNEL_SETTINGS_SCHEMA from '../schema/kernel.v0.schema.json';

which does not seem to be needed and fails downstream repos building with the error ...and cannot be used with 'export *'..

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

lite-badge 👈 Try it on ReadTheDocs

@echarles
Copy link
Author

echarles commented May 5, 2023

@jtpio
Copy link
Member

jtpio commented May 5, 2023

fails downstream repos building with the error ...and cannot be used with 'export *'..

You mean in a downstream repo reusing the extension, but without webpack?

@echarles
Copy link
Author

echarles commented May 5, 2023

it is failing while loading the node_modules while building with tsc. I am still trying to see why this is happening, and won't be able to link to a reproducer easily. Is that reexport needed?

Copy link

@911432 911432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It refers to this site.
I would like to change it like this:

export { default as KERNEL_SETTINGS_SCHEMA } from '../schema/kernel.v0.schema.json';

But I can fixed this about this[https://github.com/jupyterlite/pyodide-kernel/blob/0.3.x/packages/pyodide-kernel/scripts/generate-wheels-js.py#L80].

        "export { default as allJSONUrl } from '../pypi/all.json';",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants