Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to JupyterLab 4 and Notebook 7 #1302

Closed
wants to merge 3 commits into from
Closed

Conversation

jtpio
Copy link
Contributor

@jtpio jtpio commented Jul 24, 2023

Fixes #1095

Changes

  • Update the base environment to JupyterLab 4 and Notebook 7
  • Update to Jupyter Server 2
  • Do not update Python 3.7 in freeze.py because these new versions dropped support for Python 3.7
  • Update to jupyter-nbclassic-nbextension commands
  • Update jupyter-resource-usage to 1.0

@jtpio
Copy link
Contributor Author

jtpio commented Jul 31, 2023

Looks like a failure is related to nbgitpuller importing notebook.utils which does not exist in Notebook 7:

image

@jtpio
Copy link
Contributor Author

jtpio commented Jul 31, 2023

Looks like jupyterhub/nbgitpuller#240 should help with this.

@yuvipanda
Copy link
Collaborator

@jtpio think you'll have any time to push this forward?

@jtpio
Copy link
Contributor Author

jtpio commented Mar 25, 2024

It was paused because of the two failing tests. Maybe they will pass after a fresh rebase.

@yuvipanda
Copy link
Collaborator

Hmm, the failures look real:

Jupyter command `jupyter-nbextension` not found.

Thoughts on splitting up the upgrade to jupyterlab 4 from notebook 7? I think the jupyterlab 4 change is uncontroversial and easy. But for notebook 7, we have to figure out what to do about nbclassic, and it's a bit more of a breaking change.

@jtpio
Copy link
Contributor Author

jtpio commented Mar 28, 2024

Right doing the JupyterLab 4 update separately would be fine.

I just pushed a commit to fix a reference to jupyter-nbextension. The update to Notebook 7 would indeed break the use of jupyter-nbextension because it is now available as jupyter-nbclassic-nbextension instead.

@jtpio
Copy link
Contributor Author

jtpio commented Mar 28, 2024

Right doing the JupyterLab 4 update separately would be fine.

Opened #1340.

@minrk minrk mentioned this pull request Aug 8, 2024
@manics manics closed this in #1363 Sep 15, 2024
@jtpio jtpio deleted the lab4-nb7 branch September 15, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default to RetroLab/Jupyter Notebook 7 if/when it is released
3 participants