-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade base image from to Ubuntu 22.04 from 18.04 #1287
Conversation
18.04 was EOL May 2023, with only paid support now available (https://ubuntu.com/blog/18-04-end-of-standard-support). Let's bump the default base image to 22.04. This might break some repos that have apt.txt based packages, but I don't really think there's a way around that. If specific package pinning is needed, users unfortunately need to use a Dockerfile. Ref jupyterhub#1258
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that we need to do this, and after EOL seems like the absolute latest we can do it.
Until we have an opt-in path to selecting newer base images, we just have to make this breaking change.
How about we make an announcement https://discourse.jupyter.org/tag/announcement before merging/deploying this to mybinder.org, to manage expectations? |
Can someone else take on making the announcement? :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, it would be good to get a notice in the changelog as well under the unreleased section about this breaking change.
I've added a label about it breaking for now
I wonder if we can and should announce this via mybinder.org directly instead of discourse if its to be announced, for example in a banner during loading? If something errors by failing to get installed, this is where they will be. |
It is a great idea. |
How about both? We're using Discourse as the support forum and questions about binder are often handled by non-jupyterhub community members, so I think it's polite to give everyone advance warning. |
Both sound great. I can post to discourse. |
I opened jupyterhub/mybinder.org-deploy#2663 about not using dev releases in mybinder.org, allowing us to link out to a repo2docker's changelog etc in announcements independently if they are on made on mybinder.org or discouse, where we anyhow would need to describe breaking changes. Please signal agreement / disagreement or similar, if there is a clear agreement the fix is simple - we just adjust automation in mybinder.org-deploy to not bump to dev releases. Practically, the action plan I suggest is:
|
Announcement on the forum |
and banner for mybinder.org: jupyterhub/mybinder.org-deploy#2665 |
Conversation in jupyterhub/mybinder.org-deploy#2663 has come to a conclusion to continue current practice. I think there's been enough lead time now! Anyone wanna hit the merge button? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I locally merged this on my computer and searched for 18.04, 20.04, bionic, focal, and found no outdated references besides one now fixed - this LGTM and seems ready for merge!
I've posted one last warning https://discourse.jupyter.org/t/repo2docker-and-mybinder-org-upgrading-base-image-to-ubuntu-22-04/19865/2 |
Hi all! Wondering if this is going to get merged anytime soon? |
@yuvipanda @minrk @manics I went for a merge here. I verified that the tests still passed against the latest main branch. |
Yay, thanks @consideRatio :) |
18.04 was EOL May 2023, with only paid support now available (https://ubuntu.com/blog/18-04-end-of-standard-support).
Let's bump the default base image to 22.04. This might break some repos that have apt.txt based packages, but I don't really think there's a way around that. If specific package pinning is needed, users unfortunately need to use a Dockerfile.
Closes #1258