-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test strategy for JupyterHub v3.1.1 #479
Conversation
Ping @GeorgianaElena the tests are failing with these errors:
Seems like they are still referencing the old |
@GeorgianaElena Could the problem be the cached workflow dependencies? |
Yes, this is because the removal of the
Hmm, I believe these errors come from somewhere else and I suspect the breaking change introduced in pytest-asyncio 0.19.0 https://pytest-asyncio.readthedocs.io/en/latest/reference/changelog.html#id10 which is defaulting the So, my suggestion would be to explicitly add the |
@GeorgianaElena the test strategies for |
@Sheila-nk for sqlalchemy, you should be able to add |
This worked. Thank you! |
@minrk with restricting |
@Sheila-nk, I'd advocate not pinning I believe what @minrk suggested is to do experiment with thi pinning in #476 while integrating the pytest plugin to make sure it works. @minrk, can you please provide more details about this one? @Sheila-nk, if you drop the commit pinning sqlalchemy, I'll be comfortable merging this PR. Additionally, I believe discussions about pinning or not pinning |
Reference #476