Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded jupytercad_lab dependencies #417

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

martinRenou
Copy link
Member

This was having the downside of not being able to install it in an emscripten-wasm32 env:

error    libmamba Could not solve for environment specs
    The following packages are incompatible
    └─ jupytercad_lab is not installable because there are no viable options
       ├─ jupytercad_lab [1.0.0|1.0.1] would require
       │  └─ y-py >=0.6,<0.7 , which does not exist (perhaps a missing channel);
       └─ jupytercad_lab [2.0.0|2.0.1|2.0.2] would require
          └─ jupyterlab >=4,<5 , which requires
             └─ tornado >=6.2.0 , which does not exist (perhaps a missing channel).

@martinRenou martinRenou added the enhancement New feature or request label Sep 13, 2024
Copy link
Contributor

Preview PR at appsharing.space

Copy link
Member

@arjxn-py arjxn-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @martinRenou, looks alright to me :)

@trungleduc
Copy link
Member

Thanks!

@trungleduc trungleduc merged commit 20fdf43 into jupytercad:main Sep 14, 2024
10 checks passed
@martinRenou martinRenou deleted the fix-jcad-lab-deps branch September 16, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants