-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Notebook API into lite kernel deployment #364
Include Notebook API into lite kernel deployment #364
Conversation
why do we need to rebuild the extension and install from source? IIRC i downloaded the artifact from previous step and install the |
Ah indeed I could install the whl directly, but that's not what's being done currently |
it is done here https://github.com/jupytercad/jupytercad/blob/aaf0e39e9ce0e67877ee0c073d32dca808d6811d/.github/workflows/build.yml#L224 ? Ah, i see the issue! |
The only impact of this will be the installation of the labextensions in the build environment, then JupyterLite will pick up automatically those labextensions and include them in the lite build. But it will not install the Python package in the kernel runtime. |
This is just me trying things, I believe the notebook API should be able to open document shared models as we're going through comms with ypywidgets and not using server component. But let's try! |
7c4cae7
to
7f20018
Compare
Closing as it's apparently not possible to make this work unless the tokens for collaboration are on. |
c51dd0c
to
b64cd5e
Compare
there is no 3d view in notebook? I'm expecting an empty viewer |
you might need to set up a dev version of |
00955bc
to
723e5bc
Compare
Preview PR at appsharing.space |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
7704c7b
to
a931de5
Compare
Integration tests repot: appsharing.space |
No description provided.