Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Notebook API into lite kernel deployment #364

Merged
merged 15 commits into from
Sep 19, 2024

Conversation

martinRenou
Copy link
Member

No description provided.

Copy link
Contributor

Binder 👈 Launch a Binder on branch martinRenou/jupytercad/lite_include_notebook_api

@trungleduc
Copy link
Member

why do we need to rebuild the extension and install from source? IIRC i downloaded the artifact from previous step and install the whls directly

@martinRenou
Copy link
Member Author

Ah indeed I could install the whl directly, but that's not what's being done currently

@martinRenou martinRenou changed the title Include Notebook API into lite deployment Include Notebook API into lite kernel deployment Jun 14, 2024
@trungleduc
Copy link
Member

trungleduc commented Jun 14, 2024

Ah indeed I could install the whl directly, but that's not what's being done currently

it is done here https://github.com/jupytercad/jupytercad/blob/aaf0e39e9ce0e67877ee0c073d32dca808d6811d/.github/workflows/build.yml#L224 ?

Ah, i see the issue!

@martinRenou
Copy link
Member Author

The only impact of this will be the installation of the labextensions in the build environment, then JupyterLite will pick up automatically those labextensions and include them in the lite build.

But it will not install the Python package in the kernel runtime.

@martinRenou
Copy link
Member Author

This is just me trying things, I believe the notebook API should be able to open document shared models as we're going through comms with ypywidgets and not using server component. But let's try!

@martinRenou martinRenou marked this pull request as draft June 14, 2024 11:47
@martinRenou
Copy link
Member Author

Closing as it's apparently not possible to make this work unless the tokens for collaboration are on.

@martinRenou martinRenou deleted the lite_include_notebook_api branch June 14, 2024 13:27
@martinRenou martinRenou restored the lite_include_notebook_api branch June 24, 2024 13:30
@martinRenou martinRenou reopened this Jun 24, 2024
@martinRenou
Copy link
Member Author

For the record, this is what I get:

Screenshot from 2024-06-27 12-54-52

There is no error in the console whatsoever.

@trungleduc
Copy link
Member

trungleduc commented Jun 27, 2024

there is no 3d view in notebook? I'm expecting an empty viewer

@martinRenou
Copy link
Member Author

Yep, I'm not sure where it's blocking here:

Screenshot from 2024-06-27 13-17-29

@trungleduc
Copy link
Member

you might need to set up a dev version of yjs-widgets to debug it.

Copy link
Contributor

github-actions bot commented Sep 13, 2024

Preview PR at appsharing.space

@martinRenou martinRenou force-pushed the lite_include_notebook_api branch 2 times, most recently from 7704c7b to a931de5 Compare September 19, 2024 14:10
Copy link
Contributor

github-actions bot commented Sep 19, 2024

Integration tests repot: appsharing.space

@martinRenou martinRenou marked this pull request as ready for review September 19, 2024 14:34
@martinRenou martinRenou merged commit e3b8a81 into jupytercad:main Sep 19, 2024
8 checks passed
@martinRenou martinRenou deleted the lite_include_notebook_api branch September 19, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants