Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STEP files support #232

Merged
merged 11 commits into from
Dec 13, 2023
Merged

STEP files support #232

merged 11 commits into from
Dec 13, 2023
+13,533 −29

Conversation

martinRenou
Copy link
Member

No description provided.

@martinRenou martinRenou added the enhancement New feature or request label Dec 12, 2023
@martinRenou martinRenou marked this pull request as draft December 12, 2023 13:16
@github-actions GitHub Actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch martinRenou/jupytercad/step_brep

@trungleduc
Copy link
Member

trungleduc commented Dec 12, 2023 •
edited
Loading

you can change "build" to "build_dir" here to fix the release action

https://github.com/jupytercad/jupytercad/blob/f980c3f1196d24154038f672fbee2e86f4bf66ab/python/jupytercad_app/webpack.config.js#L32C7-L32C12

Also, need to update .gitignore

@trungleduc trungleduc added this to the 1.0.0 milestone Dec 12, 2023
@martinRenou
Copy link
Member Author

martinRenou commented Dec 12, 2023 •
edited
Loading

please update snapshots!

@martinRenou
Copy link
Member Author

Triggering CI

@martinRenou martinRenou reopened this Dec 12, 2023
@martinRenou martinRenou marked this pull request as ready for review December 12, 2023 16:17
trungleduc
trungleduc requested changes Dec 12, 2023
View reviewed changes
packages/schema/src/model.ts Outdated Show resolved Hide resolved
packages/schema/src/model.ts Outdated Show resolved Hide resolved
packages/schema/src/model.ts Show resolved Hide resolved
packages/schema/src/model.ts Show resolved Hide resolved
packages/schema/src/schema/any.json Show resolved Hide resolved
packages/occ-worker/src/occapi.ts Outdated Show resolved Hide resolved
python/jupytercad_core/src/stepplugin/modelfactory.ts Outdated Show resolved Hide resolved
martinRenou and others added 2 commits December 13, 2023 11:13
@martinRenou @trungleduc
Remove logs
74b3bfe 
Co-authored-by: Duc Trung Le <[email protected]>
@martinRenou
Review
8583053
@trungleduc
Copy link
Member

Thanks @martinRenou!

@trungleduc trungleduc merged commit 4aa1881 into jupytercad:main Dec 13, 2023
7 checks passed
@trungleduc trungleduc mentioned this pull request Dec 13, 2023
Closed
@martinRenou martinRenou deleted the step_brep branch December 13, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trungleduc trungleduc trungleduc approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@martinRenou @trungleduc