Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing dev dependency #231

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Fix missing dev dependency #231

merged 2 commits into from
Dec 12, 2023

Conversation

martinRenou
Copy link
Member

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch martinRenou/jupytercad/fix_missing_dev_install

@trungleduc
Copy link
Member

Thanks @martinRenou, since you are here, could you pin the prettier version to 3.1.0 in the pre-commit config file? E.g.

  - repo: https://github.com/pre-commit/mirrors-prettier
    rev: v3.1.0
    hooks:
      - id: prettier

@trungleduc
Copy link
Member

Thanks!

@trungleduc trungleduc merged commit f980c3f into jupytercad:main Dec 12, 2023
6 of 7 checks passed
@martinRenou martinRenou deleted the fix_missing_dev_install branch December 12, 2023 10:56
@martinRenou martinRenou changed the title Fix missing dev installation Fix missing dev dependency Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trungleduc trungleduc trungleduc approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinRenou @trungleduc