Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create jupytercad-* packages #220

Merged
merged 25 commits into from
Nov 17, 2023
Merged

Conversation

trungleduc
Copy link
Member

@trungleduc trungleduc commented Nov 9, 2023

Reference

Code changes

  • New python packages:
    • jupytercad-core: package contains core plugins for worker registry, jcad file support, doc tracker and annotation
    • jupytercad-lab: package contains plugin for lab interface and notebook support
    • jupytercad-app: the standalone Jupytercad application
  • New js packages:
    • @jupytercad/schema: package contains the schema of jcad file and related models/interfaces
    • @jupytercad/opencascade: the custom opencascade.js build for Jupytercad
    • @jupytercad/occ-worker: the opencascade worker of Jupytercad.
    • @jupytercad/base: package contains the UI components.

Remaining tasks:

  • Create meta package jupytercad
  • Update CI
  • Update jupyter-releaser config
  • Create package jupytercad-fcstd
  • Update contribution doc

@trungleduc trungleduc added enhancement New feature or request maintenance labels Nov 9, 2023
@trungleduc trungleduc added this to the 1.0.0 milestone Nov 9, 2023
Copy link
Contributor

github-actions bot commented Nov 9, 2023

Binder 👈 Launch a Binder on branch trungleduc/jupytercad/refactor

@trungleduc trungleduc force-pushed the refactor branch 2 times, most recently from 17c30f3 to 5ca3bf5 Compare November 16, 2023 15:21
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on the Python packages names. I would change the distribution names to jupytercad-core jupytercad-app etc (dash instead of underscore)

python/jupytercad-app/pyproject.toml Outdated Show resolved Hide resolved
jupytercad/__init__.py Outdated Show resolved Hide resolved
@trungleduc trungleduc marked this pull request as ready for review November 17, 2023 10:22
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks! Let's merge and fix the CI separately

@martinRenou martinRenou merged commit f1ce9a3 into jupytercad:main Nov 17, 2023
6 of 9 checks passed
@trungleduc trungleduc deleted the refactor branch January 2, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split the package into multiple sub-packages
2 participants