Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pydantic 2 #213

Merged
merged 4 commits into from
Nov 9, 2023
Merged

Support pydantic 2 #213

merged 4 commits into from
Nov 9, 2023

Conversation

trungleduc
Copy link
Member

@trungleduc trungleduc commented Nov 9, 2023

close #209

Copy link
Contributor

github-actions bot commented Nov 9, 2023

Binder 👈 Launch a Binder on branch trungleduc/jupytercad/update

@martinRenou
Copy link
Member

CI failures are unrelated, right? Let's merge and fix it separately?

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@trungleduc
Copy link
Member Author

CI failures are unrelated, right? Let's merge and fix it separately?

I'm not sure, let me check before merging.

@trungleduc
Copy link
Member Author

It looks better now, let's merge it and fix the UI test later.

@martinRenou
Copy link
Member

Well, turns out I have no right on the repo since the move! I cannot merge

@trungleduc trungleduc merged commit 12e6433 into jupytercad:main Nov 9, 2023
5 of 6 checks passed
@trungleduc
Copy link
Member Author

Well, turns out I have no right on the repo since the move! I cannot merge

Done

@martinRenou
Copy link
Member

Are you able to give me rights on the repo?

@trungleduc
Copy link
Member Author

Are you able to give me rights on the repo?

yes, i did

@martinRenou martinRenou mentioned this pull request Nov 16, 2023
@trungleduc trungleduc deleted the update branch January 2, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pydantic v2 breaks jupytercad
2 participants