Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #32
This puts the support R code into an R package called
hera
instead of having volatile R code that issource()
from the directory. The plan is forhera
to be tested as a standalone package with typical R code tools, i.e. testthat ...So currently, the kernel
void interpreter::configure_impl()
will try to loadhera
:And then e.g.
execute_request_impl()
will call the R functionexecute
that lives inhera
:SEXP result = invoke_hera_fn("execute", code_, execution_counter_, silent_);
Then the R code might need to call the routines made available by
xeusr
, e.g.This is all similar to what was, but having it in a proper package will help.
For testing purposes, i.e. when R is not embedded, and therefore those routines are not available, we'll have to replace them with mockups.
An issue I have with this, is that e need to make sure that the 📦 is installed, so I probably need to investigate that.