Fix: use jlpm to install dependencies
#128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `jlpm` to build widget
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hatch-jupyter-builderlet's us choose which package manager to use, i.e.npm,yarn, etc.This PR uses
jlpminstead ofyarnto install the NodeJS dependencies. I have no idea whether there is a reason to avoid using the bundled yarn from JupyterLab. If we want to require that users install and useyarn, then we'd need to change this toyarn. This change brings us closer to https://github.com/jupyterlab/extension-cookiecutter-ts, which usesjlpm.The benefit of
jlpmis that it's available from PyPI, so any sdist installation will just work according to PEP 517. If we requireyarnhere, builds from an sdist will fail if the host does not have the binary.Fixes #124 and fixes #126.