Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to r112 #376

Closed

Conversation

akaszynski
Copy link
Contributor

@akaszynski akaszynski commented Apr 21, 2022

Upgrade to threejs r112.

Remaining wrappers

  • PMREMGenerator (API changed from method to class, delaying wrapper)
  • LightProbe
  • LightProbeHelper
  • PositionalAudioHelper
  • SphericalHarmonics3
  • InstancedMesh
  • AmbientLightProbe
  • HemisphereLightProbe
  • PointLightShadow
  • WebGLMultisampleRenderTarget
  • WebGLMultiviewRenderTarget
  • DataTexture2DArray
  • WebGLMultiview

Changes

  • .drawMode has been removed

Bonus

@akaszynski akaszynski mentioned this pull request Apr 21, 2022
12 tasks
@akaszynski
Copy link
Contributor Author

@maartenbreddels, I'm going to try to support r112 first and then go from there.

@jasongrout, I'd like to help maintain this repository. Please message me at [email protected] if you think that's possible. I think this is an excellent repository and it's been 6 months since the last commit and around a year since a release. I'd really like to help.

@jasongrout
Copy link
Member

jasongrout commented Apr 21, 2022

Awesome, thanks for volunteering! @vidartf is the current main maintainer. @vidartf?

@codecov-commenter
Copy link

Codecov Report

Merging #376 (2a785f6) into master (a78cb57) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #376   +/-   ##
=======================================
  Coverage   70.86%   70.86%           
=======================================
  Files          23       23           
  Lines         834      834           
=======================================
  Hits          591      591           
  Misses        243      243           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@akaszynski
Copy link
Contributor Author

@jasongrout, I've not heard back from @vidartf and he's not been active on github as of late.

Is there any chance I can get hold of one of the other maintainers?

@jasongrout
Copy link
Member

@vidartf was in the ipywidgets dev meeting this morning, so pinging him again.

@vidartf
Copy link
Member

vidartf commented Apr 29, 2022

Hi @akaszynski , I'm around, and I'm more than happy to have others help out here! Thanks for volunteering! I am going to do an effort on this repo in the few coming days to add support for ipywidgets 8, but do not really plan to be working on features beyond that, so happy to leave that to you!

If you need me on a quicker turn-around than me checking my GH pings, you should be able to find my email address on the commits. Let's get a few PR's/commits through, and then get you set up with commit/publish rights after. Did you want me to review this PR in its current state?

@akaszynski akaszynski closed this Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot use cubemap in pythreejs
4 participants