Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRAFT: Single widget manager per kernel #3920

Closed
wants to merge 38 commits into from
Closed

DRAFT: Single widget manager per kernel #3920

wants to merge 38 commits into from

Commits on Mar 9, 2024

  1. Use weakref to replace strong links between widgets and comm

    Alan Fleming committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    7b393e0 View commit details
    Browse the repository at this point in the history

  2. Replaced _show_traceback decorator with a method

    Alan Fleming committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    dca56e3 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2024

  1. Fix signature of callback lamdas

    @fleming79
    fleming79 committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    871ba61 View commit details
    Browse the repository at this point in the history

  2. revise close doc

    @fleming79
    fleming79 committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    8f22131 View commit details
    Browse the repository at this point in the history

  3. change so Widget.notify_change doesn't create comm

    @fleming79
    fleming79 committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    ae6df72 View commit details
    Browse the repository at this point in the history

  4. Fix reject 'Control comm was closed too early' when comm closed as ex… 

    …pected.
    Alan Fleming committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    200edee View commit details
    Browse the repository at this point in the history

  5. Fix _show_traceback in _comm_changed

    Alan Fleming committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    24ad054 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. Added a closed property to the Widget class. Modified __repr__ to i… 

    …dentify closed widgets.

Added a new class `Children` for the children trait of Box optimised for checking widgets
and quietly dropping widgets that are closed, and objects that aren't widgets. Widgets in Box.children
 are also removed when the widget is closed.
 Added tests test_gc_box & test_gc_box_advanced
    Alan Fleming committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    2bcbed3 View commit details
    Browse the repository at this point in the history

  2. Make compatible with python3.8

    Alan Fleming committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    d3e5e29 View commit details
    Browse the repository at this point in the history

  3. Modified Widget.open to raise a runtime error if the widget is closed.

    @fleming79
    fleming79 committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    6877265 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Removed the recently added closed property, instead noting that _re… 

    …pr_mimebundle_ is set to None when closed, this reduces the risk of name clash with subclasses.

Changed Children to allow any object that has the method `_repr_mimebundle_`.
Moved box related tests to test_widget_box.
Added `close` method to Box to ensure discarded children are un-observed.
    Alan Fleming committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    f82c35c View commit details
    Browse the repository at this point in the history

  2. Made observing box children an opt-in feature with the keyword only a… 

    …rgument `observe_children`.

Updated TestBox.
    Alan Fleming committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    66ea639 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Update lock file

    Alan Fleming committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    6ff5b23 View commit details
    Browse the repository at this point in the history

  2. Ran jlpm lint

    Alan Fleming committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    4c9004d View commit details
    Browse the repository at this point in the history

  3. _widget_to_json 

    - change evaluation order to check for a widget first (most common object).
- raise NotImplementedError for objects with _repr_mimebundle_ that aren't widgets.
    Alan Fleming committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    d182a47 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. Improve error message in _widget_to_json.

    Alan Fleming committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    5448ecc View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2024

  1. Update method Widget.get_view_spec.

    @fleming79
    fleming79 committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    d1379cb View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Optimised Widget._send

    @fleming79
    fleming79 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    cecbb88 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Restore type hint info for Children.

    Alan Fleming committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    5ad3723 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2024

  1. Remove redundant type hint from Box.children.

    Alan Fleming committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    2e8c784 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2024

  1. Fix Checkbox tooltips 

    Fix 'Exception' for a Box that has been provided a tooltip.
    Alan Fleming committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    21cb6fa View commit details
    Browse the repository at this point in the history

  2. Fix tooltips for TextareaView, TextView, SelectionView.

    Alan Fleming committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    24af66b View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Fix invalid package dependencies @lumino/messaging & @lumino/algorithm. 

    Remove observe_children from 'Box'
    Alan Fleming committed May 3, 2024
    Configuration menu
    Copy the full SHA
    ce31091 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary weakrefs

    Alan Fleming committed May 3, 2024
    Configuration menu
    Copy the full SHA
    9f12504 View commit details
    Browse the repository at this point in the history

  3. Using weakreference is now opt-in.

    Alan Fleming committed May 3, 2024
    Configuration menu
    Copy the full SHA
    a634441 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2024

  1. Unify tooltips

    Alan Fleming committed May 4, 2024
    Configuration menu
    Copy the full SHA
    b1410eb View commit details
    Browse the repository at this point in the history

  2. Added model_id to errorof get_model.

    Alan Fleming committed May 4, 2024
    Configuration menu
    Copy the full SHA
    3972a9d View commit details
    Browse the repository at this point in the history

Commits on May 5, 2024

  1. Avoid attribute error on shutdown to do with _instances being None.

    Alan Fleming committed May 5, 2024
    Configuration menu
    Copy the full SHA
    f6fc921 View commit details
    Browse the repository at this point in the history

  2. Make Children validate raise TypeError for invalid items.

    Alan Fleming committed May 5, 2024
    Configuration menu
    Copy the full SHA
    fc9fb8f View commit details
    Browse the repository at this point in the history

  3. Parametrize test_weakreference.

    Alan Fleming committed May 5, 2024
    Configuration menu
    Copy the full SHA
    dbd1b19 View commit details
    Browse the repository at this point in the history

  4. Add test_box_invalid_children convert TestBox to separate pytests.

    Alan Fleming committed May 5, 2024
    Configuration menu
    Copy the full SHA
    70b88bc View commit details
    Browse the repository at this point in the history

  5. Remove dependency for istanbul-instrumenter-loader (un-maintained).

    Alan Fleming committed May 5, 2024
    Configuration menu
    Copy the full SHA
    bf3d0bc View commit details
    Browse the repository at this point in the history

  6. Fix Output tooltip issue & restored tooltip for Box. 

    Removed _model_id and revised __rer__ for a closed widget.
Added validate_mode for Box.
    Alan Fleming committed May 5, 2024
    Configuration menu
    Copy the full SHA
    0d80e29 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Modify test_weakreference for not enabled (closing should also make w… 

    …idget available for gc).
    Alan Fleming committed May 10, 2024
    Configuration menu
    Copy the full SHA
    35be63a View commit details
    Browse the repository at this point in the history

  2. Fix spelling of enable_weakreference and disable_weakreference.

    Alan Fleming committed May 10, 2024
    Configuration menu
    Copy the full SHA
    a776397 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2024

  1. Revert Link (drop _all_links). Added type annotations for link and dl… 

    …ink.
    Alan Fleming committed May 11, 2024
    Configuration menu
    Copy the full SHA
    7741dbb View commit details
    Browse the repository at this point in the history

Commits on May 19, 2024

  1. Changes to jupyterlab_widgets plugin and manager to make the KernelWi… 

    …dgetManager a singleton on a per kernel basis.

Other fixes to make widgets more accessible.
    Alan Fleming committed May 19, 2024
    Configuration menu
    Copy the full SHA
    1c4d1ad View commit details
    Browse the repository at this point in the history

Commits on May 25, 2024

  1. Use first kerenel in KernelWidgetManager.

    Alan Fleming committed May 25, 2024
    Configuration menu
    Copy the full SHA
    ae29983 View commit details
    Browse the repository at this point in the history