Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restoring widgets from saved state is broken since v8 in Lab #3866

Commits on Jan 18, 2024

  1. fix: restoring widgets from saved state is broken since v8

    In 9d999d7 waiting for sessionContext.ready was removed, this
    caused _loadNotebook() not to work, because it was called before the
    widget metadata was available.
    
    This commit restores waiting for sessionContext.ready. This has
    to be before _loadFromKernel(), otherwise this.kernel is not
    present, causing an exeption, skipping _loadNotebook().
    
    Fixes: jupyterlab/jupyterlab#15361
    mariobuikhuizen authored and martinRenou committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    c52b230 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. Configuration menu
    Copy the full SHA
    7265b2f View commit details
    Browse the repository at this point in the history
  2. ci: do not fail immediately on a screenshot mismatch

    This will make the galata report all the mismatches at the end of the
    test run, instead of failing immediately on the first mismatch.
    maartenbreddels committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    96f4915 View commit details
    Browse the repository at this point in the history
  3. ci: update snapshot

    Unsure why this is needed, since jupyter-widgets#3866 seems like an unrelated change.
    maartenbreddels committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    d374291 View commit details
    Browse the repository at this point in the history