Skip to content

Commit

Permalink
Remove confusing error message (#3936)
Browse files Browse the repository at this point in the history
This error message was introduced in #3335.

It shows up when the user refreshes the JupyterLab page on a kernel that
has not yet imported ipywidgets, because the manager requests for widgets
states, but the kernel is not able to answer back any widget model as
ipwidgets was not imported. It is a normal workflow that should not show
any error message.

This error message would also show up when using the manager with a
kernel using ipywidgets 7, in that case as well we should not show any
error message as it's a normal workflow too.

This PR removes the error message to prevent any confusion from the
user.
  • Loading branch information
martinRenou committed Aug 22, 2024
1 parent 0aa1efb commit 69efca9
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions packages/base-manager/src/manager-base.ts
Original file line number Diff line number Diff line change
Expand Up @@ -427,10 +427,6 @@ export abstract class ManagerBase implements IWidgetManager {

initComm.close();
} catch (error) {
console.warn(
'Failed to fetch ipywidgets through the "jupyter.widget.control" comm channel, fallback to fetching individual model state. Reason:',
error
);
// Fall back to the old implementation for old ipywidgets backend versions (ipywidgets<=7.6)
return this._loadFromKernelModels();
}
Expand Down

0 comments on commit 69efca9

Please sign in to comment.