Skip to content

Commit

Permalink
Manager, WidgetManager and plugin refactoring (simplification) . Warn…
Browse files Browse the repository at this point in the history
…ing: some signature changes.
  • Loading branch information
Alan Fleming committed Jun 3, 2024
1 parent fe50eb6 commit 1bb65f4
Show file tree
Hide file tree
Showing 6 changed files with 184 additions and 281 deletions.
2 changes: 1 addition & 1 deletion packages/base-manager/src/manager-base.ts
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ export abstract class ManagerBase implements IWidgetManager {
async get_model(model_id: string): Promise<WidgetModel> {
let i = 0;
while (!this._models[model_id] && i < this._sleepTimes.length) {
new Promise((r) => setTimeout(r, this._sleepTimes[i++]))
new Promise((resolve) => setTimeout(resolve, this._sleepTimes[i++]));
}
const modelPromise = this._models[model_id];
if (modelPromise === undefined) {
Expand Down
2 changes: 0 additions & 2 deletions python/jupyterlab_widgets/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@
"@jupyterlab/services": "^6.0.0 || ^7.0.0",
"@jupyterlab/settingregistry": "^3.0.0 || ^4.0.0",
"@jupyterlab/translation": "^3.0.0 || ^4.0.0",
"@lumino/algorithm": "^1.11.1 || ^2.0.0",
"@lumino/coreutils": "^1.11.1 || ^2.1",
"@lumino/disposable": "^1.10.1 || ^2.1",
"@lumino/properties": "^2.0.1",
Expand All @@ -76,7 +75,6 @@
},
"devDependencies": {
"@jupyterlab/builder": "^3.0.0 || ^4.0.0",
"@jupyterlab/cells": "^3.0.0 || ^4.0.0",
"@types/jquery": "^3.5.16",
"@types/semver": "^7.3.6",
"@typescript-eslint/eslint-plugin": "^5.8.0",
Expand Down
Loading

0 comments on commit 1bb65f4

Please sign in to comment.