Skip to content

Commit

Permalink
Remove unnecessary hitTest
Browse files Browse the repository at this point in the history
Signed-off-by: Itay Dafna <[email protected]>
  • Loading branch information
ibdafna committed Nov 2, 2022
1 parent ca4fae7 commit 0c2c4ce
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions js/core/filterMenu.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ import { DataModel } from '@lumino/datagrid';

import { Signal, ISignal } from '@lumino/signaling';

import { ElementExt } from '@lumino/domutils';

import { Message, MessageLoop, ConflatableMessage } from '@lumino/messaging';

import { BasicMouseHandler } from '@lumino/datagrid';
Expand Down Expand Up @@ -460,10 +458,7 @@ export class InteractiveFilterDialog extends BoxPanel {
*/
protected _evtMouseDown(event: MouseEvent) {
// Close the menu if a click is detected anywhere else
if (
!ElementExt.hitTest(this.node, event.clientX, event.clientY) &&
!this.node.contains(event.target as HTMLElement)
) {
if (!this.node.contains(event.target as HTMLElement)) {
this.close();
}
}
Expand Down

0 comments on commit 0c2c4ce

Please sign in to comment.