Avoid temporary objects #683
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjasny
force-pushed
the
avoid-temporary-objects
branch
from
83bab6f
to
5675de5
Compare
gjasny
force-pushed
the
avoid-temporary-objects
branch
from
5675de5
to
cfa3ecb
Compare
Is there any way to tell otel-cpp whether to use the new class |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When collecting many metrics, the intermediate
std::vector<MetricFamily>objects can heavily grow in size and cause memory fragmentation (see #646). This PR implements direct text-serialization into a buffer array whose buffers are 1 MByte at maximum.The extreme memory fragmentation that I saw with the glibc allocator as well as the huge memory spikes during collection are now gone. There are now multiple other optimization possibilities, but this is the bare minimum needed.