Add constructor injection support for ParameterizedTest SPIs #4025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcphilipp
force-pushed
the
marc/4018-parameterized-spi-constructor-injection
branch
from
4734bff
to
a62a2d0
Compare
marcphilipp
force-pushed
the
marc/4018-parameterized-spi-constructor-injection
branch
from
a62a2d0
to
0aef290
Compare
sbrannen
requested changes
Sep 25, 2024
...-jupiter-params/src/main/java/org/junit/jupiter/params/ParameterizedTestSpiInstantiator.java
Outdated
Show resolved
Hide resolved
sbrannen
approved these changes
Sep 25, 2024
marcphilipp
deleted the
marc/4018-parameterized-spi-constructor-injection
branch
sbrannen
reviewed
Sep 25, 2024
...-jupiter-params/src/main/java/org/junit/jupiter/params/ParameterizedTestSpiInstantiator.java
Show resolved
Hide resolved
sbrannen
added a commit
that referenced
this pull request
Sep 25, 2024
Since Class.getDeclaredConstructors() clones the constructors array AND makes "child copies" of the constructors, it's usually better to avoid repeated calls to getDeclaredConstructors() for a single use case. In addition, it's good to avoid the use of Optional, multiple Streams, and try-catch blocks if feasible. This commit reworks ParameterizedTestSpiInstantiator in order to achieve that by switching to old-school Java constructs like arrays, for-loops, and if-blocks. See #4018 See #4025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Resolves #4018.
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations