Introduce zero invocations in test templates and parameterized tests #3890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a flag to ParameterizedTest to control arguments requirement. This allows users to explicitly opt out from validation of arguments set count and silently skip a test if no arguments are provided In general, support TestTemplateInvocationContextProvider returning zero invocation contexts. Such providers must override new interface method to indicate that the framework should expect "no context returned" Resolves junit-team#1477
|
Need this feature a lot! Is there a forecast for when it will be ready? |
marcphilipp
requested changes
Sep 23, 2024
| * @since 5.11 | ||
| */ | ||
| @API(status = EXPERIMENTAL, since = "5.11") | ||
| default boolean mayReturnEmptyInvocationContext(ExtensionContext extensionContext) { |
There was a problem hiding this comment.
Suggested change
| default boolean mayReturnEmptyInvocationContext(ExtensionContext extensionContext) { | |
| default boolean mayReturnZeroInvocationContexts(ExtensionContext context) { |
| () -> "None of the supporting " + TestTemplateInvocationContextProvider.class.getSimpleName() + "s " | ||
| + providers.stream().map(provider -> provider.getClass().getSimpleName()).collect( | ||
| joining(", ", "[", "]")) | ||
| + providers.stream().filter(p -> !p.mayReturnEmptyInvocationContext(extensionContext)).map( |
There was a problem hiding this comment.
I don't think we should filter them out here.
| * to be invoked; never {@code null} | ||
| * @return {@code true} to allow zero contexts, {@code false} (default) to fail execution in case of zero contexts. | ||
| * | ||
| * @since 5.11 |
Comment on lines
+105
to
+107
| return findAnnotation(templateMethod, ParameterizedTest.class).map( | ||
| parameterizedTest -> !parameterizedTest.requireArguments()).orElse( | ||
| TestTemplateInvocationContextProvider.super.mayReturnEmptyInvocationContext(extensionContext)); |
There was a problem hiding this comment.
Suggested change
| return findAnnotation(templateMethod, ParameterizedTest.class).map( | |
| parameterizedTest -> !parameterizedTest.requireArguments()).orElse( | |
| TestTemplateInvocationContextProvider.super.mayReturnEmptyInvocationContext(extensionContext)); | |
| return findAnnotation(templateMethod, ParameterizedTest.class) // | |
| .map(parameterizedTest -> !parameterizedTest.requireArguments()) // | |
| .orElse(false); |
Comment on lines
+91
to
+92
| * Signals that in the given {@linkplain ExtensionContext extension context} the provider may return zero | ||
| * {@linkplain TestTemplateInvocationContext invocation contexts} |
There was a problem hiding this comment.
Suggested change
| * Signals that in the given {@linkplain ExtensionContext extension context} the provider may return zero | |
| * {@linkplain TestTemplateInvocationContext invocation contexts} | |
| * Signals that in the supplied {@linkplain ExtensionContext context} the provider may return zero | |
| * {@linkplain TestTemplateInvocationContext invocation contexts}. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a flag to ParameterizedTest to control arguments requirement. This allows users to explicitly opt out from validation of arguments set count and silently skip a test if no arguments are provided
In general, support TestTemplateInvocationContextProvider returning zero invocation contexts. Such providers must override new interface method to indicate that the framework should expect "no context returned"
Resolves #1477
Overview
Implemented the team decision described in this comment
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations