Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor : eradicate formatted string #569

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

refactor : eradicate formatted string #569

wants to merge 5 commits into from
+16 −24

Conversation

mirageoasis
Copy link
Contributor

I tracked down formatted string and changed ramaining strings

@mirageoasis mirageoasis changed the title refactor : eradicate f-string refactor : eradicate formatted string Oct 20, 2023
@mirageoasis
Copy link
Contributor Author

When I used f-string it cannot call pymysql.cursor._escape_args which cause error in process

dongwook-chan
dongwook-chan requested changes Oct 21, 2023
View reviewed changes
pymysqlreplication/binlogstream.py Outdated Show resolved Hide resolved
@julien-duponchelle
Copy link
Owner

I like this upgrade to modern Python !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongwook-chan dongwook-chan dongwook-chan requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mirageoasis @julien-duponchelle @dongwook-chan