Resolves in code review

julien-duponchelle · Dec 4, 2023 · 93b0c3f · 93b0c3f
1 parent 9c04832
commit 93b0c3f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/pymysqlreplication/tests/base.py b/pymysqlreplication/tests/base.py
@@ -74,6 +74,10 @@ def isMySQL57(self):
         version = float(self.getMySQLVersion().rsplit(".", 1)[0])
         return version == 5.7
 
+    def isMySQL57AndMore(self):
+        version = float(self.getMySQLVersion().rsplit(".", 1)[0])
+        return version >= 5.7
+
     def isMySQL80AndMore(self):
         version = float(self.getMySQLVersion().rsplit(".", 1)[0])
         return version >= 8.0

diff --git a/pymysqlreplication/tests/test_basic.py b/pymysqlreplication/tests/test_basic.py
@@ -1488,6 +1488,8 @@ def test_gtid_event(self):
             server_id=1024,
             only_events=[GtidEvent],
         )
+        if not self.isMySQL57AndMore():
+            self.skipTest("Mysql version is under 5.7")
         self.execute(
             "CREATE TABLE IF NOT EXISTS test (id INT AUTO_INCREMENT PRIMARY KEY, name VARCHAR(255))"
         )