[JUJU-3600] Remove 32-bit word arch support #330
+106
−274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the arch package from the utils module. The arch package was only there to serve juju/juju directly. It dictated what was supported in side of juju. The juju project should dictate what architectures are supported, not a common utils package. The arch package will be moved into juju/juju project, within the core package.
SimonRichardson
force-pushed
the
remove-arches
branch
from
e33db1f
to
dc9f6a0
Compare
|
The failures are not part of the changes: |
manadart
approved these changes
Apr 25, 2023
|
/merge |
SimonRichardson
force-pushed
the
remove-arches
branch
from
1e62742
to
a1e4769
Compare
SimonRichardson
force-pushed
the
remove-arches
branch
from
a1e4769
to
604c952
Compare
3 tasks
SimonRichardson
changed the title
jujubot
added a commit
to juju/juju
that referenced
this pull request
Apr 28, 2023
#15534 This is the first step in fixing the problematic arch supported list from LXD. Whilst investigating that bug, it seems that we still support 32-bit word sizes. Except that, we no longer want to support 32-bit word sizes with dqlite, as the number of jujud permutations explodes and so it's best to completely remove the support. We officially dropped support for 32-bit architectures over 3 years ago, although we didn't actively remove the code to drop support. This brings in what the juju/utils arch support had, with the addition of a UnsupportedArches field, which will ensure that we can at least say what we use to support, but no longer do. This doesn't bring in the changes from [juju/utils PR](juju/utils#330) as technically we don't need a new version of juju/utils sans arch package to do this. ## Checklist - [x] Code style: imports ordered, good names, simple structure, etc - [x] Comments saying why design decisions were made - [x] Go unit tests, with comments saying what you're testing ## QA steps ```sh $ juju bootstrap lxd test --build-agent ``` ## Bug reference https://bugs.launchpad.net/juju/+bug/2013869
|
/build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the arch package from the utils module. The arch package was only there to serve juju/juju directly. It dictated what was supported inside of juju. The juju project should dictate what architectures are supported, not a common utils package.
The arch package will be moved into juju/juju project, within the core package. In doing so, I've bumped this package to v4, to indicate the breaking change.