Fix console app name #1335
Closed
Fix console app name #1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ide an AudioIODeviceCombiner
When dragging-and-dropping a plugin into the plugin host, it was possible that the subprocess scanner could fail to send a response. This would cause the superprocess to freeze, waiting for a reply. With this change in place, the subprocess will always send a response after scanning on the main thread.
…cessful PE response headers
This allows the LookAndFeel of submenus to query the target component used for the top-level menu. getTargetComponent() isn't suitable for this because the target component is set to null for submenus, and this behaviour can't be changed without potentially breaking code that relies on the current behaviour.
…reating one - Also refactored internals to use weak/shared pointers
This change affects the DatagramSocket and StreamingSocket classes.
Prior to this change all <tspan> elements without x, and y attributes would just inherit the parent elements such attributes and be placed in the same location. This didn't respect whether these attributes were consumed already by the parent. Having multiple x and y elements, or having a different number of x and y elements was also not handled in line with the rules for SVG.
…n using WebView2 This fixes a bug where moving a window between displays with different scaling settings makes the embedded WebView misaligned.
… member channels are always 0
…tion callbacks are interleaved viewDidDisappear may be called when a file is successfully selected. presentationControllerDidDismiss is only called when the controller is dismissed manually by the user, e.g. by tapping outside the sheet, or by dragging it away. Checking for sheet dismissal is necessary in iOS 15, but not in iOS 17. In iOS 17, tapping outside the file chooser causes a callback to documentPickerWasCancelled instead.
…oot window rather than the application window
…nicated to the edit controller
- Prevent out of scope access of the listeners lock - Allow clearing the listener list from a callback
…allback This fixes an edge case in which if listeners are both removed and added during a callback the added listener(s) may be called during the same iteration
This also adds missing KHRONOS_APIENTRY qualifications to the debug callback type, which fixes potential crashes when running debug Win32 builds.
The new class hold a list of ChildProcesses and periodically checks their return value until they report termination. On Linux this check is necessary to avoid leaving zombie processes behind.
…eave zombies This change also avoids the AudioPluginHost leaving zombie child processes behind.
…ponent is modal The change does not affect plugin windows, which are created by the host.
The old API only allowed cancelling property "get" inquiries and subscription updates. However, there are use-cases for cancelling other requests too. e.g. switching between views in a JUCE app might mean that it's no longer necessary to subscribe to a particular property. Cancelling subscriptions ends up being quite involved. Different handling is needed depending on whether the subscription is cancelled before or after the responder replies to the initial request. In addition, the responder may ask the initiator to retry a subscription begin request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a pull request.
Please make sure you have read and followed our contribution guidelines (.github/contributing.md in this repository). Your pull request will not be accepted if you have not followed the instructions.