ThreadPool: Improve consistency with other option style classes

juce-framework · Jun 28, 2023 · 578d2b9 · 578d2b9
1 parent 04a8900
commit 578d2b9
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/modules/juce_core/threads/juce_ThreadPool.cpp b/modules/juce_core/threads/juce_ThreadPool.cpp
@@ -25,7 +25,7 @@ namespace juce
 
 struct ThreadPool::ThreadPoolThread  : public Thread
 {
-    ThreadPoolThread (ThreadPool& p, const ThreadPoolOptions& options)
+    ThreadPoolThread (ThreadPool& p, const Options& options)
        : Thread { options.threadName, options.threadStackSizeBytes },
          pool { p }
     {
@@ -94,7 +94,7 @@ ThreadPoolJob* ThreadPoolJob::getCurrentThreadPoolJob()
 }
 
 //==============================================================================
-ThreadPool::ThreadPool (const ThreadPoolOptions& options)
+ThreadPool::ThreadPool (const Options& options)
 {
     // not much point having a pool without any threads!
     jassert (options.numberOfThreads > 0);
@@ -109,9 +109,9 @@ ThreadPool::ThreadPool (const ThreadPoolOptions& options)
 ThreadPool::ThreadPool (int numberOfThreads,
                         size_t threadStackSizeBytes,
                         Thread::Priority desiredThreadPriority)
-    : ThreadPool { ThreadPoolOptions{}.withNumberOfThreads (numberOfThreads)
-                                      .withThreadStackSizeBytes (threadStackSizeBytes)
-                                      .withDesiredThreadPriority (desiredThreadPriority) }
+    : ThreadPool { Options{}.withNumberOfThreads (numberOfThreads)
+                            .withThreadStackSizeBytes (threadStackSizeBytes)
+                            .withDesiredThreadPriority (desiredThreadPriority) }
 {
 }
 

diff --git a/modules/juce_core/threads/juce_ThreadPool.h b/modules/juce_core/threads/juce_ThreadPool.h
@@ -200,13 +200,15 @@ struct ThreadPoolOptions
 class JUCE_API  ThreadPool
 {
 public:
+    using Options = ThreadPoolOptions;
+
     //==============================================================================
     /** Creates a thread pool based on the provided options.
         Once you've created a pool, you can give it some jobs by calling addJob().
 
         @see ThreadPool::ThreadPoolOptions
     */
-    explicit ThreadPool (const ThreadPoolOptions& options);
+    explicit ThreadPool (const Options& options);
 
     /** Creates a thread pool based using the default arguments provided by
         ThreadPoolOptions.
@@ -215,7 +217,7 @@ class JUCE_API  ThreadPool
 
         @see ThreadPoolOptions
     */
-    ThreadPool() : ThreadPool { ThreadPoolOptions{} } {}
+    ThreadPool() : ThreadPool { Options{} } {}
 
     /** Creates a thread pool.
         Once you've created a pool, you can give it some jobs by calling addJob().