Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ctrl+c on examples copies the whole text #74

Merged
merged 7 commits into from
Sep 22, 2024

Conversation

AkshataABhat
Copy link
Contributor

@AkshataABhat AkshataABhat commented Sep 15, 2024

closes #53

Copy link
Member

@JeelRajodiya JeelRajodiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @AkshataABhat! We have solve the problem, but I noticed one side effect of these changes.
Some of the codeblocks have few lines highlighted in green, and since we are disabling the line wrapping. there will be no elements that wrap the lines, so the green highlights have disappeared. Can you please also resolve it?

image

@AkshataABhat
Copy link
Contributor Author

Yes, will do @JeelRajodiya 👍

@JeelRajodiya
Copy link
Member

Any updates @AkshataABhat?

@AkshataABhat
Copy link
Contributor Author

@JeelRajodiya pls check this pr.

Copy link
Member

@JeelRajodiya JeelRajodiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please ensure that these highlights have the full width (same as the codeblock) and does not have gaps between the lines?

Screenshot 2024-09-22 134033

@AkshataABhat
Copy link
Contributor Author

AkshataABhat commented Sep 22, 2024

Done @JeelRajodiya , please check.

@JeelRajodiya JeelRajodiya changed the title fixes to ctrl+c issue on code snippet fix: ctrl+c on examples copies the whole text Sep 22, 2024
@JeelRajodiya
Copy link
Member

Congrats Akshata! it works perfectly!

@JeelRajodiya JeelRajodiya merged commit 9c7836f into json-schema-org:main Sep 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ctrl+c on examples copies the whole text, not just the selection
2 participants