Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Best Practices section #50

Merged
merged 7 commits into from
Jul 6, 2022
Merged

Conversation

anatoly-scherbakov
Copy link
Contributor

@anatoly-scherbakov anatoly-scherbakov commented Jul 5, 2022

Best practices

This PR is to propose some thoughts I had derived from discussions held in the issues of this repo. It adds a new informative section to the spec modeled after (and referencing) JSON-LD Best Practices document.

It would seem that the consensus of the group is a strong intention to keep YAML-LD and JSON-LD convertible from one to another using mainstream JSON and YAML tools. That means the proposed hard-wired $ ←→ @ conversion is not feasible.

As an alternative, a special context was suggested in a discussion, and that is implemented in this PR. I thought that adding it as a normative requirement would be a bit too restrictive — that was the main motivation to include a new non-normative section to the doc, to suggest this context just as a possible solution.

  1. Do you think this could be part of the spec? Or perhaps it should be a separate document? My reason to add it here was to a) make it easier to manage all the efforts in the view that b) spec is currently quite small so perhaps adding one little section won't hurt it.
  2. What do you think about the convenience context as a suggestion in the spec?

I will probably add a few more UCRs for other questions touched by this PR.

Thank you!


Preview | Diff

spec/index.html Outdated Show resolved Hide resolved
Copy link
Member

@gkellogg gkellogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider wrapping lines on natural boundaries, which make it easier to make change suggestions through GitHub.

Not sure I agree with all of the best practices you propose, but it's an interesting point of discussion.

@anatoly-scherbakov
Copy link
Contributor Author

Line wraps added, thank you for pointing out.

spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
@VladimirAlexiev
Copy link
Contributor

@anatoly-scherbakov

proposed hard-wired $ ←→ @ conversion is not feasible

Agreed it cannot be the only or the default option.

But I think there should be an option sigil: or prefix_char: where I can pick my own: $ or _ etc

@OR13
Copy link

OR13 commented Jul 6, 2022

yaml supports '@', I don't think we should encourage additional sigils... but if we do, we better allow for '💎' to be used.

@gkellogg
Copy link
Member

gkellogg commented Jul 6, 2022

This PR was discussed in the 2022-07-06 meeting, and it was agreed to merge.

@gkellogg
Copy link
Member

gkellogg commented Jul 6, 2022

@anatoly-scherbakov I've added you to the team, which allows you to make branches within this repo. That way, it's easier for others to collaborate on your PRs. Please reconcile the conflicts in your branch and we can merge.

@gkellogg gkellogg merged commit e0af936 into json-ld:main Jul 6, 2022
@anatoly-scherbakov anatoly-scherbakov deleted the best-practices branch July 7, 2022 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants