Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YAML files are streams #49

Merged
merged 3 commits into from
Jul 5, 2022
Merged

YAML files are streams #49

merged 3 commits into from
Jul 5, 2022

Conversation

ioggstream
Copy link
Contributor

@ioggstream ioggstream commented Jul 5, 2022 •
edited by pr-preview bot
Loading

This PR

  • clarify that files are streams
  • streams can contain one or more documents
  • the specification is related to documents and reflects on streams.

Preview | Diff

gkellogg
gkellogg approved these changes Jul 5, 2022
View reviewed changes
Copy link
Member

@gkellogg gkellogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! A couple of suggestions inline.

spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
ioggstream and others added 2 commits July 5, 2022 21:11
@ioggstream @gkellogg
Update spec/index.html
e6beddc 
Co-authored-by: Gregg Kellogg <[email protected]>
@ioggstream @gkellogg
Update spec/index.html
9c192e5 
Co-authored-by: Gregg Kellogg <[email protected]>
@ioggstream ioggstream changed the base branch from main to ioggstream-38 July 5, 2022 19:14
@ioggstream ioggstream changed the base branch from ioggstream-38 to ioggstream-8 July 5, 2022 19:15
@ioggstream
Copy link
Contributor Author

@gkellogg PR should target branch ioggstream-8 :) so that it can be applied after merging 34 #34

@gkellogg
Copy link
Member

gkellogg commented Jul 5, 2022

Great, I can apply it to that branch now. Or, you could. It simplifies the work of the CG to have fewer PRs to look at, and these things are reasonably described in #34 already. Easier than merging #34 and forgetting to have applied this PR.

@gkellogg gkellogg merged commit b27637b into ioggstream-8 Jul 5, 2022
@gkellogg gkellogg deleted the ioggstream-46 branch July 5, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkellogg gkellogg gkellogg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ioggstream @gkellogg