-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid name clashing in ros msg packages #609
base: master
Are you sure you want to change the base?
Conversation
Adopting the first one for simplicity and to avoid re-generating the messages. Since no coding is performed from inside the ros message packages this should have no side effects (tests will confirm that for us). |
040b7a2
to
b6395b9
Compare
Added test code |
roseus does not depend on jsk_recognition_msgs, so I think it is better to create message for test code, like https://github.com/jsk-ros-pkg/jsk_roseus/pull/509/files. |
b6395b9
to
b926d5a
Compare
👍 for this PR. |
@knorth55 Actually we had some test failures and possible bugs here. I'll try to have a look on this week and make any necessary changes to reactivate this |
Solves #574.