[naoqieus] add led fading method (new version of #812) #999
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
Naoqi robot can change LED color.
Requirements
https://github.com/kochigami/naoqi_driver/tree/kochigami-develop
https://github.com/kochigami/naoqi_bridge_msgs/tree/kochigami-develop
Tested with
Pepper 2.5.5.5, NAO 2.1.4 ROS kinetic
Difference between this PR and [naoqieus] add led fading method #812
this PR uses naoqi_driver service: add fading/ resetting leds services ros-naoqi/naoqi_driver#100 and add fade leds srv ros-naoqi/naoqi_bridge_msgs#41
812 uses naoqi_bridge service: [naoqi_apps] add node and launch for ALLeds (wip) ros-naoqi/naoqi_bridge#84 and add msg and srv for naoqi_leds ros-naoqi/naoqi_bridge_msgs#33
Both of them are written by me, and it will take some time to be merged.
If so, I think gathering basic functions into
naoqi_driver
(= add fading/ resetting leds services ros-naoqi/naoqi_driver#100) is good.TODO
add explanation about kochigami-develop [jsk_naoqi_robot/README] Add explanation of roseus interface methods #1000
add explanation about these functions [jsk_naoqi_robot/README] Add explanation of roseus interface methods #1000
(especially LED group name, link to NAOqi documentation)