Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jsk_201504_miraikan] mirai-demo-20150413.l: delete services we can't use now #816

Merged
merged 8 commits into from
Nov 21, 2018
Merged

[jsk_201504_miraikan] mirai-demo-20150413.l: delete services we can't use now #816

merged 8 commits into from
Nov 21, 2018

Conversation

kochigami
Copy link
Contributor

@kochigami kochigami commented Aug 7, 2017 •
edited
Loading

  • modify the program in order to execute demo :en with current jsk_pepper_startup

TODO

  • need to take care of :set-master-volume method in naoqi-interface.l
    (editted: created add set/ get volume eus method #814 )
  • check it with other languages (japanese, chinese)
    (editted: done!)

@kochigami kochigami mentioned this pull request Nov 16, 2018
Open
kochigami
kochigami commented Nov 16, 2018
View reviewed changes
jsk_naoqi_robot/jsk_201504_miraikan/README.md
please move mp3 files in file directory you want Pepper to speak under ``` /home/nao/audio_file . If not, please make ```audio_file``` folder in ```/home/nao/```. You can use ```scp <file> nao@<Pepper IP>:/home/nao/audio_file/```.
How to run demo?
----------------

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to add Naoqi version and ROS version which I confirmed that this works.
In addition, I have to add version of other packages which this package depends on.

@kochigami
Copy link
Contributor Author

Now this demo can be executed only with jsk_pepper_startup.launch and this package.

This PR depends on #996.
(And #996 depends on ros-naoqi/naoqi_driver#109.)

@kochigami
Copy link
Contributor Author

kochigami commented Nov 20, 2018 •
edited
Loading

I created kochigami-develop branch for naoqi_driver and naoqi_bridge_msgs, which includes some PRs which have not been merged yet.
I added information about that branch on README.

I think after #996 is merged, we can merge this PR.

[Edit] I confirmed this PR works with Pepper 2.5.5.5 and ROS kinetic.

@kochigami kochigami closed this Nov 21, 2018
@kochigami kochigami reopened this Nov 21, 2018
@kochigami
Copy link
Contributor Author

@k-okada
Could you please merge this when you have time?

@k-okada k-okada merged commit d18c60a into jsk-ros-pkg:master Nov 21, 2018
@kochigami kochigami deleted the delete-unable-to-use-service branch November 21, 2018 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
naoqi need fix WaitForUpstream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kochigami @k-okada