Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add image_height and image_width in PanoramaInfo #2753

Merged
merged 9 commits into from
Jan 25, 2023

Conversation

knorth55
Copy link
Member

@knorth55 knorth55 commented Dec 7, 2022

this PR add image_height and image_width field in PanoramaInfo.
this infomation is used in rect_array_in_panoram_to_bounding_box.py.
PanoramaInfo is lighter than PanoramaImage, and rect_array_in_panoram_to_bounding_box.py only needs the shape information, thus I add this field.
related: #2752

cc. @AyumuIwa

@knorth55
Copy link
Member Author

knorth55 commented Dec 7, 2022

I checked this PR with #2754 , and it works.

Screencast.2022-12-07.23.11.53.mp4

@sktometometo
Copy link
Contributor

この変更見ていて気づいたんですが、PanoramaInfo に画像の情報入れてしまうと、画像だけresizeして使うという使い方はできなくなりますね.

@sktometometo
Copy link
Contributor

sktometometo commented Dec 13, 2022

#2754 にあるresizeオプションは消した方がいいかと思います。

@sktometometo
Copy link
Contributor

sample に使っている rosbag の変更も必要そうです

@knorth55
Copy link
Member Author

rosbagはまだとっていません.
#2754 の resizeオプションを消しました.

@knorth55
Copy link
Member Author

knorth55 commented Dec 13, 2022

とおもったけど,やっぱりpanorama info resizeのスクリプトを書くことにしました.
resizeについては#2754 に含まれています.

@k-okada k-okada self-assigned this Jan 25, 2023
@k-okada k-okada merged commit c71ebaf into jsk-ros-pkg:master Jan 25, 2023
@knorth55 knorth55 deleted the panorama-info-image-shape branch January 26, 2023 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants